Commit ccc495ef authored Apr 03, 2018 by Dan Carpenter Committed by Martin K. Petersen Apr 09, 2018

scsi: cxgb4i: silence overflow warning in t4_uld_rx_handler()



Smatch marks skb->data as untrusted so it complains that there is a
potential overflow here:

	drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:2111 t4_uld_rx_handler()
	error: buffer overflow 'cxgb4i_cplhandlers' 239 <= 255.

In this case, skb->data comes from the hardware or firmware so it's not
going to overflow unless there is a firmware bug.

[mkp: fixed braces]

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 7709e9bd

drivers/scsi/cxgbi/cxgb4i/cxgb4i.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -2108,12 +2108,12 @@ static int t4_uld_rx_handler(void handle, const __be64 rsp,
		log_debug(1 << CXGBI_DBG_TOE,
		"cdev %p, opcode 0x%x(0x%x,0x%x), skb %p.\n",
		cdev, opc, rpl->ot.opcode_tid, ntohl(rpl->ot.opcode_tid), skb);
		if (cxgb4i_cplhandlers[opc])
		cxgb4i_cplhandlers[opc](cdev, skb);
		else {
		if (opc >= ARRAY_SIZE(cxgb4i_cplhandlers) \|\| !cxgb4i_cplhandlers[opc]) {
		pr_err("No handler for opcode 0x%x.\n", opc);
		__kfree_skb(skb);
		}
		} else
		cxgb4i_cplhandlers[opc](cdev, skb);

		return 0;
		nomem:
		log_debug(1 << CXGBI_DBG_TOE, "OOM bailing out.\n");