Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc5bd925 authored by tang.junhui's avatar tang.junhui Committed by Mike Snitzer
Browse files

dm mpath: add checks for priority group count to avoid invalid memory access 



This avoids the potential for invalid memory access, if/when there are
no priority groups, in response to invalid arguments being sent by the
user via DM message (e.g. "switch_group", "disable_group" or
"enable_group").

Signed-off-by: default avatartang.junhui <tang.junhui@zte.com.cn>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
parent f97dc421

drivers/md/dm-mpath.c

+2 −2
Original line number Diff line number Diff line
@@ -1364,7 +1364,7 @@ static int switch_pg_num(struct multipath *m, const char *pgstr) 
	char dummy;



	if (!pgstr || (sscanf(pgstr, "%u%c", &pgnum, &dummy) != 1) || !pgnum ||

	    (pgnum > m->nr_priority_groups)) {

	    !m->nr_priority_groups || (pgnum > m->nr_priority_groups)) {

		DMWARN("invalid PG number supplied to switch_pg_num");

		return -EINVAL;

	}
@@ -1396,7 +1396,7 @@ static int bypass_pg_num(struct multipath *m, const char *pgstr, bool bypassed) 
	char dummy;



	if (!pgstr || (sscanf(pgstr, "%u%c", &pgnum, &dummy) != 1) || !pgnum ||

	    (pgnum > m->nr_priority_groups)) {

	    !m->nr_priority_groups || (pgnum > m->nr_priority_groups)) {

		DMWARN("invalid PG number supplied to bypass_pg");

		return -EINVAL;

	}