Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc4d623d authored by Vasanthakumar Thiagarajan's avatar Vasanthakumar Thiagarajan Committed by Kalle Valo
Browse files

ath6kl: Remove bogus non-NULL pointer check 



In ath6kl_cfg80211_add_key(), params is checked for non-NULL
but this pointer has been deferenced many times before this check. This
gives the following smatch warning. add_key() can never carry NULL as
params, remove this bogus check.

ath6kl_cfg80211_add_key(86) warn: variable dereferenced before check 'params'

Signed-off-by: default avatarVasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent e8ad9a06

drivers/net/wireless/ath/ath6kl/cfg80211.c

+1 −1
Original line number Diff line number Diff line
@@ -1059,7 +1059,7 @@ static int ath6kl_cfg80211_add_key(struct wiphy *wiphy, struct net_device *ndev, 


	if (vif->nw_type == AP_NETWORK && !pairwise &&

	    (key_type == TKIP_CRYPT || key_type == AES_CRYPT ||

	     key_type == WAPI_CRYPT) && params) {

	     key_type == WAPI_CRYPT)) {

		ar->ap_mode_bkey.valid = true;

		ar->ap_mode_bkey.key_index = key_index;

		ar->ap_mode_bkey.key_type = key_type;