Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc4a84c3 authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller
Browse files

net: phy: bcm7xxx: Fix 7425 PHY ID and flags 



While adding support for 7425 PHY in the 7xxx PHY driver, the ID that
was used was actually coming from an external PHY: a BCM5461x. Fix this
by using the proper ID for the internal 7425 PHY and set the
PHY_IS_INTERNAL flag, otherwise consumers of this PHY driver would not
be able to properly identify it as such.

Fixes: d068b02c ("net: phy: add BCM7425 and BCM7429 PHYs")
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Reviewed-by: default avatarPetri Gynther <pgynther@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cf539cbd

drivers/net/phy/bcm7xxx.c

+1 −1
Original line number Diff line number Diff line
@@ -404,7 +404,7 @@ static struct phy_driver bcm7xxx_driver[] = { 
	.name           = "Broadcom BCM7425",

	.features       = PHY_GBIT_FEATURES |

			  SUPPORTED_Pause | SUPPORTED_Asym_Pause,

	.flags          = 0,

	.flags          = PHY_IS_INTERNAL,

	.config_init    = bcm7xxx_config_init,

	.config_aneg    = genphy_config_aneg,

	.read_status    = genphy_read_status,

include/linux/brcmphy.h

+1 −1
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ 
#define PHY_ID_BCM7250			0xae025280

#define PHY_ID_BCM7364			0xae025260

#define PHY_ID_BCM7366			0x600d8490

#define PHY_ID_BCM7425			0x03625e60

#define PHY_ID_BCM7425			0x600d86b0

#define PHY_ID_BCM7429			0x600d8730

#define PHY_ID_BCM7439			0x600d8480

#define PHY_ID_BCM7439_2		0xae025080