Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ca1b10b8 authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (emc2103) Fix overflows seen when temperature limit attributes 



Writes into temperature limit attributes can overflow due to unbound
values passed to DIV_ROUND_CLOSEST().

Cc: Steve Glendinning <steve.glendinning@shawell.net>
Reviewed-by: default avatarJean Delvare <jdelvare@suse.de>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 67b20034

drivers/hwmon/emc2103.c

+2 −2
Original line number Diff line number Diff line
@@ -251,7 +251,7 @@ static ssize_t set_temp_min(struct device *dev, struct device_attribute *da, 
	if (result < 0)

		return result;



	val = clamp_val(DIV_ROUND_CLOSEST(val, 1000), -63, 127);

	val = DIV_ROUND_CLOSEST(clamp_val(val, -63000, 127000), 1000);



	mutex_lock(&data->update_lock);

	data->temp_min[nr] = val;
@@ -273,7 +273,7 @@ static ssize_t set_temp_max(struct device *dev, struct device_attribute *da, 
	if (result < 0)

		return result;



	val = clamp_val(DIV_ROUND_CLOSEST(val, 1000), -63, 127);

	val = DIV_ROUND_CLOSEST(clamp_val(val, -63000, 127000), 1000);



	mutex_lock(&data->update_lock);

	data->temp_max[nr] = val;