Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c9eabf40 authored May 25, 2017 by Uwe Kleine-König Committed by Tony Lindgren May 31, 2017

memory: omap-gpmc: add error message if bank-width property is absent



Instead of failing silently log a hint for the dt author about the
reason of the failure.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>

parent 95c278b2

drivers/memory/omap-gpmc.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -2083,9 +2083,12 @@ static int gpmc_probe_generic_child(struct platform_device *pdev,
		} else {
		ret = of_property_read_u32(child, "bank-width",
		&gpmc_s.device_width);
		if (ret < 0)
		if (ret < 0) {
		dev_err(&pdev->dev, "%s has no 'bank-width' property\n",
		child->full_name);
		goto err;
		}
		}

		/* Reserve wait pin if it is required and valid */
		if (gpmc_s.wait_on_read \|\| gpmc_s.wait_on_write) {