Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c9008d33 authored by Thomas Falcon's avatar Thomas Falcon Committed by David S. Miller
Browse files

ibmvnic: Update firmware error reporting with cause string 



Print a string instead of the error code. Since there is a
possibility that the driver can recover, classify it as a
warning instead of an error.

Signed-off-by: default avatarThomas Falcon <tlfalcon@linux.vnet.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 79dabbb7

drivers/net/ethernet/ibm/ibmvnic.c

+30 −4
Original line number Diff line number Diff line
@@ -3825,15 +3825,41 @@ static void handle_query_ip_offload_rsp(struct ibmvnic_adapter *adapter) 
	ibmvnic_send_crq(adapter, &crq);

}



static const char *ibmvnic_fw_err_cause(u16 cause)

{

	switch (cause) {

	case ADAPTER_PROBLEM:

		return "adapter problem";

	case BUS_PROBLEM:

		return "bus problem";

	case FW_PROBLEM:

		return "firmware problem";

	case DD_PROBLEM:

		return "device driver problem";

	case EEH_RECOVERY:

		return "EEH recovery";

	case FW_UPDATED:

		return "firmware updated";

	case LOW_MEMORY:

		return "low Memory";

	default:

		return "unknown";

	}

}



static void handle_error_indication(union ibmvnic_crq *crq,

				    struct ibmvnic_adapter *adapter)

{

	struct device *dev = &adapter->vdev->dev;

	u16 cause;



	cause = be16_to_cpu(crq->error_indication.error_cause);



	dev_err(dev, "Firmware reports %serror, cause %d\n",

	dev_warn_ratelimited(dev,

			     "Firmware reports %serror, cause: %s. Starting recovery...\n",

			     crq->error_indication.flags

				& IBMVNIC_FATAL_ERROR ? "FATAL " : "",

		be16_to_cpu(crq->error_indication.error_cause));

			     ibmvnic_fw_err_cause(cause));



	if (crq->error_indication.flags & IBMVNIC_FATAL_ERROR)

		ibmvnic_reset(adapter, VNIC_RESET_FATAL);