Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c899f935 authored by Archit Taneja's avatar Archit Taneja Committed by Rob Clark
Browse files

drm/msm/hdmi: Prevent gpio_free related kernel warnings 



Calling the legacy gpio_free on an invalid GPIO (a GPIO numbered -1)
results in kernel warnings. This causes a lot of backtraces when
we try to unload the drm/msm module.

Call gpio_free only on valid GPIOs.

Signed-off-by: default avatarArchit Taneja <architt@codeaurora.org>
Signed-off-by: default avatarRob Clark <robdclark@gmail.com>
parent 4816b626

drivers/gpu/drm/msm/hdmi/hdmi_connector.c

+7 −2
Original line number Diff line number Diff line
@@ -112,6 +112,9 @@ static int gpio_config(struct hdmi *hdmi, bool on) 
		for (i = 0; i < HDMI_MAX_NUM_GPIO; i++) {

			struct hdmi_gpio_data gpio = config->gpios[i];



			if (gpio.num == -1)

				continue;



			if (gpio.output) {

				int value = gpio.value ? 0 : 1;
@@ -126,8 +129,10 @@ static int gpio_config(struct hdmi *hdmi, bool on) 


	return 0;

err:

	while (i--)

	while (i--) {

		if (config->gpios[i].num != -1)

			gpio_free(config->gpios[i].num);

	}



	return ret;

}