Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c84b66f8 authored by Sylwester Nawrocki's avatar Sylwester Nawrocki Committed by Inki Dae
Browse files

drm: exynos: Use proper macro definition for HDMI_I2S_PIN_SEL_1 



Bit field [2:0] of HDMI_I2S_PIN_SEL_1 corresponds to SDATA_0,
not SDATA_2. This patch removes redefinition of HDMI_I2S_SEL_DATA2
constant and adds missing HDMI_I2S_SEL_DATA0.
The value of bit field selecting SDATA_1 (pin_sel_3) is also changed,
so it is 3 as suggested in the Exynos TRMs.

Signed-off-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarInki Dae <inki.dae@samsung.com>
parent b701a143

drivers/gpu/drm/exynos/exynos_hdmi.c

+5 −2
Original line number Diff line number Diff line
@@ -1068,10 +1068,13 @@ static void hdmi_audio_config(struct hdmi_context *hdata) 
	/* Configuration I2S input ports. Configure I2S_PIN_SEL_0~4 */

	hdmi_reg_writeb(hdata, HDMI_I2S_PIN_SEL_0, HDMI_I2S_SEL_SCLK(5)

			| HDMI_I2S_SEL_LRCK(6));

	hdmi_reg_writeb(hdata, HDMI_I2S_PIN_SEL_1, HDMI_I2S_SEL_SDATA1(1)

			| HDMI_I2S_SEL_SDATA2(4));



	hdmi_reg_writeb(hdata, HDMI_I2S_PIN_SEL_1, HDMI_I2S_SEL_SDATA1(3)

			| HDMI_I2S_SEL_SDATA0(4));



	hdmi_reg_writeb(hdata, HDMI_I2S_PIN_SEL_2, HDMI_I2S_SEL_SDATA3(1)

			| HDMI_I2S_SEL_SDATA2(2));



	hdmi_reg_writeb(hdata, HDMI_I2S_PIN_SEL_3, HDMI_I2S_SEL_DSD(0));



	/* I2S_CON_1 & 2 */

drivers/gpu/drm/exynos/regs-hdmi.h

+1 −1
Original line number Diff line number Diff line
@@ -464,7 +464,7 @@ 


/* I2S_PIN_SEL_1 */

#define HDMI_I2S_SEL_SDATA1(x)		(((x) & 0x7) << 4)

#define HDMI_I2S_SEL_SDATA2(x)		((x) & 0x7)

#define HDMI_I2S_SEL_SDATA0(x)		((x) & 0x7)



/* I2S_PIN_SEL_2 */

#define HDMI_I2S_SEL_SDATA3(x)		(((x) & 0x7) << 4)