Commit c759174e authored Dec 21, 2015 by Linus Walleij

gpio: mpc8xxx: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Alexander Stein <alexander.stein@systec-electronic.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 6f14dd69

drivers/gpio/gpio-mpc8xxx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -79,7 +79,7 @@ static int mpc8572_gpio_get(struct gpio_chip *gc, unsigned int gpio)
		val = in_be32(mm->regs + GPIO_DAT) & ~out_mask;
		out_shadow = mpc8xxx_gc->data & out_mask;

		return (val \| out_shadow) & mpc8xxx_gpio2mask(gpio);
		return !!((val \| out_shadow) & mpc8xxx_gpio2mask(gpio));
		}

		static int mpc8xxx_gpio_get(struct gpio_chip *gc, unsigned int gpio)