Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c6a056a3 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

bnx2x: small fix in stats handling 



Use a private variable to fold rx_dropped value, instead of shared
destination buffer, as it might break SNMP applications.

Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
CC: Eilon Greenstein <eilong@broadcom.com>
CC: Dmitry Kravkov <dmitry@broadcom.com>
Acked-By: default avatarEilon Greenstein <eilong@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c061b18d

drivers/net/bnx2x/bnx2x_stats.c

+4 −3
Original line number Diff line number Diff line
@@ -969,6 +969,7 @@ static void bnx2x_net_stats_update(struct bnx2x *bp) 
{

	struct bnx2x_eth_stats *estats = &bp->eth_stats;

	struct net_device_stats *nstats = &bp->dev->stats;

	unsigned long tmp;

	int i;



	nstats->rx_packets =
@@ -985,10 +986,10 @@ static void bnx2x_net_stats_update(struct bnx2x *bp) 


	nstats->tx_bytes = bnx2x_hilo(&estats->total_bytes_transmitted_hi);



	nstats->rx_dropped = estats->mac_discard;

	tmp = estats->mac_discard;

	for_each_queue(bp, i)

		nstats->rx_dropped +=

			le32_to_cpu(bp->fp[i].old_tclient.checksum_discard);

		tmp += le32_to_cpu(bp->fp[i].old_tclient.checksum_discard);

	nstats->rx_dropped = tmp;



	nstats->tx_dropped = 0;