Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c51d411f authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Bjorn Helgaas
Browse files

PCI: rcar: Fix error handling of irq_of_parse_and_map() 



Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating
failure, so testing for negative result never works.

Signed-off-by: default avatarDmitry Torokhov <dtor@chromium.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarPhil Edworthy <phil.edworthy@renesas.com>
parent 97bf6af1

drivers/pci/host/pcie-rcar.c

+2 −2
Original line number Diff line number Diff line
@@ -757,7 +757,7 @@ static int rcar_pcie_get_resources(struct platform_device *pdev, 
		goto err_map_reg;



	i = irq_of_parse_and_map(pdev->dev.of_node, 0);

	if (i < 0) {

	if (!i) {

		dev_err(pcie->dev, "cannot get platform resources for msi interrupt\n");

		err = -ENOENT;

		goto err_map_reg;
@@ -765,7 +765,7 @@ static int rcar_pcie_get_resources(struct platform_device *pdev, 
	pcie->msi.irq1 = i;



	i = irq_of_parse_and_map(pdev->dev.of_node, 1);

	if (i < 0) {

	if (!i) {

		dev_err(pcie->dev, "cannot get platform resources for msi interrupt\n");

		err = -ENOENT;

		goto err_map_reg;