Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c51ad34e authored by Wei Yongjun's avatar Wei Yongjun Committed by Samuel Ortiz
Browse files

NFC: Move the pn544_hci dereference below the NULL test 

The dereference should be moved below the NULL test.

spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/

)

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent d6650a2c

drivers/nfc/pn544_hci.c

+6 −3
Original line number Diff line number Diff line
@@ -346,13 +346,16 @@ static int pn544_hci_i2c_read(struct i2c_client *client, struct sk_buff **skb) 
static irqreturn_t pn544_hci_irq_thread_fn(int irq, void *dev_id)

{

	struct pn544_hci_info *info = dev_id;

	struct i2c_client *client = info->i2c_dev;

	struct i2c_client *client;

	struct sk_buff *skb = NULL;

	int r;



	BUG_ON(!info);

	BUG_ON(irq != info->i2c_dev->irq);

	if (!info || irq != info->i2c_dev->irq) {

		WARN_ON_ONCE(1);

		return IRQ_NONE;

	}



	client = info->i2c_dev;

	dev_dbg(&client->dev, "IRQ\n");



	if (info->hard_fault != 0)