Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c5098ebb authored by Thomas Graf's avatar Thomas Graf Committed by David S. Miller
Browse files

ila: Fix tailroom allocation of lwtstate 



Tailroom is supposed to be of length sizeof(struct ila_lwt) but
sizeof(struct ila_params) is currently allocated.

This leads to the dst_cache and connected member of ila_lwt being
referenced out of bounds.

struct ila_lwt {
	struct ila_params p;
	struct dst_cache dst_cache;
	u32 connected : 1;
};

Fixes: 65d7ab8d ("net: Identifier Locator Addressing module")
Signed-off-by: default avatarThomas Graf <tgraf@suug.ch>
Acked-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7b1536ef

net/ipv6/ila/ila_lwt.c

+1 −1
Original line number Diff line number Diff line
@@ -122,7 +122,7 @@ static int ila_build_state(struct net_device *dev, struct nlattr *nla, 
	struct ila_lwt *ilwt;

	struct ila_params *p;

	struct nlattr *tb[ILA_ATTR_MAX + 1];

	size_t encap_len = sizeof(*p);

	size_t encap_len = sizeof(*ilwt);

	struct lwtunnel_state *newts;

	const struct fib6_config *cfg6 = cfg;

	struct ila_addr *iaddr;