Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c506d91d authored by Gerrit Renker's avatar Gerrit Renker
Browse files

dccp: Unused argument in CCID tx function 



This removes the argument `more' from ccid_hc_tx_packet_sent, since it was
nowhere used in the entire code.

(Anecdotally, this argument was not even used in the original KAME code where
 the function originally came from; compare the variable moreToSend in the
 freebsd61-dccp-kame-28.08.2006.patch now maintained by Emmanuel Lochin.)

Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
parent f10ecaee

net/dccp/ccid.h

+3 −3
Original line number Diff line number Diff line
@@ -71,7 +71,7 @@ struct ccid_operations { 
	int		(*ccid_hc_tx_send_packet)(struct sock *sk,

						  struct sk_buff *skb);

	void		(*ccid_hc_tx_packet_sent)(struct sock *sk,

						  int more, unsigned int len);

						  unsigned int len);

	void		(*ccid_hc_rx_get_info)(struct sock *sk,

					       struct tcp_info *info);

	void		(*ccid_hc_tx_get_info)(struct sock *sk,
@@ -139,10 +139,10 @@ static inline int ccid_hc_tx_send_packet(struct ccid *ccid, struct sock *sk, 
}



static inline void ccid_hc_tx_packet_sent(struct ccid *ccid, struct sock *sk,

					  int more, unsigned int len)

					  unsigned int len)

{

	if (ccid->ccid_ops->ccid_hc_tx_packet_sent != NULL)

		ccid->ccid_ops->ccid_hc_tx_packet_sent(sk, more, len);

		ccid->ccid_ops->ccid_hc_tx_packet_sent(sk, len);

}



static inline void ccid_hc_rx_packet_recv(struct ccid *ccid, struct sock *sk,

net/dccp/ccids/ccid2.c

+1 −1
Original line number Diff line number Diff line
@@ -221,7 +221,7 @@ static void ccid2_start_rto_timer(struct sock *sk) 
		       jiffies + hctx->rto);

}



static void ccid2_hc_tx_packet_sent(struct sock *sk, int more, unsigned int len)

static void ccid2_hc_tx_packet_sent(struct sock *sk, unsigned int len)

{

	struct dccp_sock *dp = dccp_sk(sk);

	struct ccid2_hc_tx_sock *hctx = ccid2_hc_tx_sk(sk);

net/dccp/ccids/ccid3.c

+1 −2
Original line number Diff line number Diff line
@@ -356,8 +356,7 @@ static int ccid3_hc_tx_send_packet(struct sock *sk, struct sk_buff *skb) 
	return 0;

}



static void ccid3_hc_tx_packet_sent(struct sock *sk, int more,

				    unsigned int len)

static void ccid3_hc_tx_packet_sent(struct sock *sk, unsigned int len)

{

	struct ccid3_hc_tx_sock *hctx = ccid3_hc_tx_sk(sk);

net/dccp/output.c

+1 −1
Original line number Diff line number Diff line
@@ -301,7 +301,7 @@ void dccp_write_xmit(struct sock *sk, int block) 
				dcb->dccpd_type = DCCP_PKT_DATA;



			err = dccp_transmit_skb(sk, skb);

			ccid_hc_tx_packet_sent(dp->dccps_hc_tx_ccid, sk, 0, len);

			ccid_hc_tx_packet_sent(dp->dccps_hc_tx_ccid, sk, len);

			if (err)

				DCCP_BUG("err=%d after ccid_hc_tx_packet_sent",

					 err);