Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c4d8199b authored by Yoshihiro Shimoda's avatar Yoshihiro Shimoda Committed by Felipe Balbi
Browse files

usb: renesas_usbhs: protect mod->irq_{bemp,brdy}sts by spin lock 



This patch protects the mod->irq_bempsts and mod->irq_brdysts by
spin lock in the usbhs_status_get_each_irq() because other functions
will write them during spin lock. Otherwise, the driver will clears
the BRDYSTS and/or BEMPSTS wrongly, and then, the transaction will not
finish.
Also since the driver should use the INTSTS0 and BRDYSTS and BEMPSTS
as the same timing, the patch protects them.

Signed-off-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 8355b2b3

drivers/usb/renesas_usbhs/mod.c

+5 −0
Original line number Diff line number Diff line
@@ -213,7 +213,10 @@ static int usbhs_status_get_each_irq(struct usbhs_priv *priv, 
{

	struct usbhs_mod *mod = usbhs_mod_get_current(priv);

	u16 intenb0, intenb1;

	unsigned long flags;



	/********************  spin lock ********************/

	usbhs_lock(priv, flags);

	state->intsts0 = usbhs_read(priv, INTSTS0);

	state->intsts1 = usbhs_read(priv, INTSTS1);
@@ -229,6 +232,8 @@ static int usbhs_status_get_each_irq(struct usbhs_priv *priv, 
		state->bempsts &= mod->irq_bempsts;

		state->brdysts &= mod->irq_brdysts;

	}

	usbhs_unlock(priv, flags);

	/********************  spin unlock ******************/



	/*

	 * Check whether the irq enable registers and the irq status are set