Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c4326563 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Ingo Molnar
Browse files

efivars: Call guid_parse() against guid_t type of variable 



uuid_le_to_bin() is deprecated API and take into consideration that variable,
to where we store parsed data, is type of guid_t we switch to guid_parse()
for sake of consistency.

While here, add error checking to it.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Lukas Wunner <lukas@wunner.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/20180720014726.24031-10-ard.biesheuvel@linaro.org


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent e8f4194d

fs/efivarfs/inode.c

+3 −1
Original line number Diff line number Diff line
@@ -86,7 +86,9 @@ static int efivarfs_create(struct inode *dir, struct dentry *dentry, 
	/* length of the variable name itself: remove GUID and separator */

	namelen = dentry->d_name.len - EFI_VARIABLE_GUID_LEN - 1;



	uuid_le_to_bin(dentry->d_name.name + namelen + 1, &var->var.VendorGuid);

	err = guid_parse(dentry->d_name.name + namelen + 1, &var->var.VendorGuid);

	if (err)

		goto out;



	if (efivar_variable_is_removable(var->var.VendorGuid,

					 dentry->d_name.name, namelen))