Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c402b947 authored by Yan Burman's avatar Yan Burman Committed by David S. Miller
Browse files

net/mlx4_en: Use generic etherdevice.h functions. 



Get rid of full_mac, zero_mac in favour of
is_zero_ether_addr and is_broadcast_ether_addr.

Signed-off-by: default avatarYan Burman <yanb@mellanox.com>
Signed-off-by: default avatarAmir Vadai <amirv@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d4676eac

drivers/net/ethernet/mellanox/mlx4/en_ethtool.c

+2 −4
Original line number Diff line number Diff line
@@ -613,8 +613,6 @@ static int mlx4_en_validate_flow(struct net_device *dev, 
	struct ethtool_usrip4_spec *l3_mask;

	struct ethtool_tcpip4_spec *l4_mask;

	struct ethhdr *eth_mask;

	u64 full_mac = ~0ull;

	u64 zero_mac = 0;



	if (cmd->fs.location >= MAX_NUM_OF_FS_RULES)

		return -EINVAL;
@@ -644,11 +642,11 @@ static int mlx4_en_validate_flow(struct net_device *dev, 
	case ETHER_FLOW:

		eth_mask = &cmd->fs.m_u.ether_spec;

		/* source mac mask must not be set */

		if (memcmp(eth_mask->h_source, &zero_mac, ETH_ALEN))

		if (!is_zero_ether_addr(eth_mask->h_source))

			return -EINVAL;



		/* dest mac mask must be ff:ff:ff:ff:ff:ff */

		if (memcmp(eth_mask->h_dest, &full_mac, ETH_ALEN))

		if (!is_broadcast_ether_addr(eth_mask->h_dest))

			return -EINVAL;



		if (!all_zeros_or_all_ones(eth_mask->h_proto))