Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c35ec779 authored by Yangbo Lu's avatar Yangbo Lu Committed by David S. Miller
Browse files

gianfar_ptp: replace get_of_u32 with of_property_read_u32 



Replace get_of_u32 with standard helper function of_property_read_u32
since the latter can process cpu endianness.

Signed-off-by: default avatarYangbo Lu <yangbo.lu@nxp.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3db66fdc

drivers/net/ethernet/freescale/gianfar_ptp.c

+13 −20
Original line number Diff line number Diff line
@@ -422,19 +422,6 @@ static struct ptp_clock_info ptp_gianfar_caps = { 
	.enable		= ptp_gianfar_enable,

};



/* OF device tree */



static int get_of_u32(struct device_node *node, char *str, u32 *val)

{

	int plen;

	const u32 *prop = of_get_property(node, str, &plen);



	if (!prop || plen != sizeof(*prop))

		return -1;

	*val = *prop;

	return 0;

}



static int gianfar_ptp_probe(struct platform_device *dev)

{

	struct device_node *node = dev->dev.of_node;
@@ -452,15 +439,21 @@ static int gianfar_ptp_probe(struct platform_device *dev) 


	etsects->caps = ptp_gianfar_caps;



	if (get_of_u32(node, "fsl,cksel", &etsects->cksel))

	if (of_property_read_u32(node, "fsl,cksel", &etsects->cksel))

		etsects->cksel = DEFAULT_CKSEL;



	if (get_of_u32(node, "fsl,tclk-period", &etsects->tclk_period) ||

	    get_of_u32(node, "fsl,tmr-prsc", &etsects->tmr_prsc) ||

	    get_of_u32(node, "fsl,tmr-add", &etsects->tmr_add) ||

	    get_of_u32(node, "fsl,tmr-fiper1", &etsects->tmr_fiper1) ||

	    get_of_u32(node, "fsl,tmr-fiper2", &etsects->tmr_fiper2) ||

	    get_of_u32(node, "fsl,max-adj", &etsects->caps.max_adj)) {

	if (of_property_read_u32(node,

				 "fsl,tclk-period", &etsects->tclk_period) ||

	    of_property_read_u32(node,

				 "fsl,tmr-prsc", &etsects->tmr_prsc) ||

	    of_property_read_u32(node,

				 "fsl,tmr-add", &etsects->tmr_add) ||

	    of_property_read_u32(node,

				 "fsl,tmr-fiper1", &etsects->tmr_fiper1) ||

	    of_property_read_u32(node,

				 "fsl,tmr-fiper2", &etsects->tmr_fiper2) ||

	    of_property_read_u32(node,

				 "fsl,max-adj", &etsects->caps.max_adj)) {

		pr_err("device tree node missing required elements\n");

		goto no_node;

	}