Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2ce34c0 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

genirq/debugfs: Remove pointless NULL pointer check 



debugfs_remove() has it's own NULL pointer check. Remove the conditional
and make irq_remove_debugfs_entry() an inline helper

Reported-by: default avatarkbuild test robot <fengguang.wu@intel.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 8d9d51b6

kernel/irq/debugfs.c

+0 −7
Original line number Diff line number Diff line
@@ -3,7 +3,6 @@ 
 *

 * This file is licensed under the GPL V2.

 */

#include <linux/debugfs.h>

#include <linux/irqdomain.h>

#include <linux/irq.h>
@@ -191,12 +190,6 @@ void irq_add_debugfs_entry(unsigned int irq, struct irq_desc *desc) 
						 &dfs_irq_ops);

}



void irq_remove_debugfs_entry(struct irq_desc *desc)

{

	if (desc->debugfs_file)

		debugfs_remove(desc->debugfs_file);

}



static int __init irq_debugfs_init(void)

{

	struct dentry *root_dir;

kernel/irq/internals.h

+6 −1
Original line number Diff line number Diff line
@@ -318,8 +318,13 @@ static inline bool irq_fixup_move_pending(struct irq_desc *desc, bool fclear) 
#endif /* !CONFIG_GENERIC_PENDING_IRQ */



#ifdef CONFIG_GENERIC_IRQ_DEBUGFS

#include <linux/debugfs.h>



void irq_add_debugfs_entry(unsigned int irq, struct irq_desc *desc);

void irq_remove_debugfs_entry(struct irq_desc *desc);

static inline void irq_remove_debugfs_entry(struct irq_desc *desc)

{

	debugfs_remove(desc->debugfs_file);

}

# ifdef CONFIG_IRQ_DOMAIN

void irq_domain_debugfs_init(struct dentry *root);

# else