Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2c80529 authored by Al Viro's avatar Al Viro Committed by Ingo Molnar
Browse files

tracing, alpha: undefined reference to `save_stack_trace' 



Impact: build fix on !stacktrace architectures

only select STACKTRACE on architectures that have STACKTRACE_SUPPORT

... since we also need to ifdef out the guts of ftrace_trace_stack().
We also want to disallow setting TRACE_ITER_STACKTRACE in trace_flags
on such configs, but that can wait.

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Acked-by: default avatarSteven Rostedt <srostedt@redhat.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 45beca08

kernel/trace/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -25,7 +25,7 @@ config TRACING 
	bool

	select DEBUG_FS

	select RING_BUFFER

	select STACKTRACE

	select STACKTRACE if STACKTRACE_SUPPORT

	select TRACEPOINTS

	select NOP_TRACER

kernel/trace/trace.c

+2 −0
Original line number Diff line number Diff line
@@ -705,6 +705,7 @@ static void ftrace_trace_stack(struct trace_array *tr, 
			       unsigned long flags,

			       int skip, int pc)

{

#ifdef CONFIG_STACKTRACE

	struct ring_buffer_event *event;

	struct stack_entry *entry;

	struct stack_trace trace;
@@ -730,6 +731,7 @@ static void ftrace_trace_stack(struct trace_array *tr, 


	save_stack_trace(&trace);

	ring_buffer_unlock_commit(tr->buffer, event, irq_flags);

#endif

}



void __trace_stack(struct trace_array *tr,