Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2967731 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Linus Walleij
Browse files

gpio: aspeed: fix compile testing warning 



Gcc cannot always see that BUG_ON(1) is guaranteed to not
return, so we get a warning message in some configurations:

drivers/gpio/gpio-aspeed.c: In function 'bank_reg':
drivers/gpio/gpio-aspeed.c:244:1: error: control reaches end of non-void function [-Werror=return-type]

Using a plain BUG() is easier here and avoids the problem.

Fixes: 44ddf559 ("gpio: aspeed: Rework register type accessors")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Acked-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 80956790

drivers/gpio/gpio-aspeed.c

+1 −1
Original line number Diff line number Diff line
@@ -240,7 +240,7 @@ static inline void __iomem *bank_reg(struct aspeed_gpio *gpio, 
	case reg_cmdsrc1:

		return gpio->base + bank->cmdsrc_regs + GPIO_CMDSRC_1;

	}

	BUG_ON(1);

	BUG();

}



#define GPIO_BANK(x)	((x) >> 5)