Commit c22e853a authored Jul 30, 2016 by Wei Yongjun Committed by Ilya Dryomov Aug 08, 2016

libceph: fix return value check in alloc_msg_with_page_vector()



In case of error, the function ceph_alloc_page_vector() returns
ERR_PTR() and never returns NULL. The NULL test in the return value
check should be replaced with IS_ERR().

Fixes: 19079203 ('libceph: support for sending notifies')
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

parent 29b4817d

net/ceph/osd_client.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4220,7 +4220,7 @@ static struct ceph_msg alloc_msg_with_page_vector(struct ceph_msg_header hdr)

		pages = ceph_alloc_page_vector(calc_pages_for(0, data_len),
		GFP_NOIO);
		if (!pages) {
		if (IS_ERR(pages)) {
		ceph_msg_put(m);
		return NULL;
		}