Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c047e5f3 authored by Michael S. Tsirkin's avatar Michael S. Tsirkin
Browse files

vhost-net: update used ring on backend change



On backend change, we flushed out outstanding skbs
but forgot to update the used ring, so that
done entries were left in the ubuf_info ring.
As a result we lose heads or complete incorrect ones,
crashing the guest or leaking memory.
Fix by updating the used ring.

Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent b834226b
Loading
Loading
Loading
Loading
+5 −1
Original line number Diff line number Diff line
@@ -711,8 +711,12 @@ static long vhost_net_set_backend(struct vhost_net *n, unsigned index, int fd)

	mutex_unlock(&vq->mutex);

	if (oldubufs)
	if (oldubufs) {
		vhost_ubuf_put_and_wait(oldubufs);
		mutex_lock(&vq->mutex);
		vhost_zerocopy_signal_used(vq);
		mutex_unlock(&vq->mutex);
	}

	if (oldsock) {
		vhost_net_flush_vq(n, index);