Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c02bc350 authored by Felix Fietkau's avatar Felix Fietkau Committed by David S. Miller
Browse files

bgmac: fix MAC soft-reset bit for corerev > 4 



Only core revisions older than 4 use BGMAC_CMDCFG_SR_REV0. This mainly
fixes support for BCM4708A0KF SoCs with Ethernet core rev 5 (it means
only some devices as most of BCM4708A0KF-s got core rev 4).
This was tested for regressions on BCM47094 which doesn't seem to care
which bit gets used.

Signed-off-by: default avatarFelix Fietkau <nbd@openwrt.org>
Signed-off-by: default avatarRafał Miłecki <zajec5@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 01c445a4

drivers/net/ethernet/broadcom/bgmac.h

+3 −3
Original line number Diff line number Diff line
@@ -199,9 +199,9 @@ 
#define  BGMAC_CMDCFG_TAI			0x00000200

#define  BGMAC_CMDCFG_HD			0x00000400	/* Set if in half duplex mode */

#define  BGMAC_CMDCFG_HD_SHIFT			10

#define  BGMAC_CMDCFG_SR_REV0			0x00000800	/* Set to reset mode, for other revs */

#define  BGMAC_CMDCFG_SR_REV4			0x00002000	/* Set to reset mode, only for core rev 4 */

#define  BGMAC_CMDCFG_SR(rev)  ((rev == 4) ? BGMAC_CMDCFG_SR_REV4 : BGMAC_CMDCFG_SR_REV0)

#define  BGMAC_CMDCFG_SR_REV0			0x00000800	/* Set to reset mode, for core rev 0-3 */

#define  BGMAC_CMDCFG_SR_REV4			0x00002000	/* Set to reset mode, for core rev >= 4 */

#define  BGMAC_CMDCFG_SR(rev)  ((rev >= 4) ? BGMAC_CMDCFG_SR_REV4 : BGMAC_CMDCFG_SR_REV0)

#define  BGMAC_CMDCFG_ML			0x00008000	/* Set to activate mac loopback mode */

#define  BGMAC_CMDCFG_AE			0x00400000

#define  BGMAC_CMDCFG_CFE			0x00800000