Commit bff7e067 authored Aug 08, 2016 by Wei Yongjun Committed by Mike Snitzer Nov 21, 2016

dm flakey: return -EINVAL on interval bounds error in flakey_ctr()



Fix to return error code -EINVAL instead of 0, as is done elsewhere in
this function.

Fixes: e80d1c80 ("dm: do not override error code returned from dm_get_device()")
Cc: stable@vger.kernel.org # 4.3+
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>

parent 1b1b58f5

drivers/md/dm-flakey.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -200,11 +200,13 @@ static int flakey_ctr(struct dm_target ti, unsigned int argc, char *argv)

		if (!(fc->up_interval + fc->down_interval)) {
		ti->error = "Total (up + down) interval is zero";
		r = -EINVAL;
		goto bad;
		}

		if (fc->up_interval + fc->down_interval < fc->up_interval) {
		ti->error = "Interval overflow";
		r = -EINVAL;
		goto bad;
		}