Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bef292a7 authored by Steven Whitehouse's avatar Steven Whitehouse
Browse files

GFS2: Remove obsolete quota tunable 



There is no need for a paramater which relates to the internals
of quota to be exposed to users. The only possible use would be
to turn it up so large that the memory allocation fails. So lets
remove it and set it to a sensible value which ensures that we
don't ask for multipage allocations.

Currently the size of struct gfs2_holder means that the caluclated
value is identical to the previous default value, so there should
be no functional change.

Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
Cc: Abhijith Das <adas@redhat.com>
parent 26e43a15

fs/gfs2/incore.h

+0 −1
Original line number Diff line number Diff line
@@ -537,7 +537,6 @@ struct gfs2_tune { 


	unsigned int gt_logd_secs;



	unsigned int gt_quota_simul_sync; /* Max quotavals to sync at once */

	unsigned int gt_quota_warn_period; /* Secs between quota warn msgs */

	unsigned int gt_quota_scale_num; /* Numerator */

	unsigned int gt_quota_scale_den; /* Denominator */

fs/gfs2/ops_fstype.c

+0 −1
Original line number Diff line number Diff line
@@ -51,7 +51,6 @@ static void gfs2_tune_init(struct gfs2_tune *gt) 
{

	spin_lock_init(&gt->gt_spin);



	gt->gt_quota_simul_sync = 64;

	gt->gt_quota_warn_period = 10;

	gt->gt_quota_scale_num = 1;

	gt->gt_quota_scale_den = 1;

fs/gfs2/quota.c

+1 −1
Original line number Diff line number Diff line
@@ -1140,7 +1140,7 @@ int gfs2_quota_sync(struct super_block *sb, int type) 
{

	struct gfs2_sbd *sdp = sb->s_fs_info;

	struct gfs2_quota_data **qda;

	unsigned int max_qd = gfs2_tune_get(sdp, gt_quota_simul_sync);

	unsigned int max_qd = PAGE_SIZE/sizeof(struct gfs2_holder);

	unsigned int num_qd;

	unsigned int x;

	int error = 0;

fs/gfs2/sys.c

+0 −2
Original line number Diff line number Diff line
@@ -587,7 +587,6 @@ TUNE_ATTR(max_readahead, 0); 
TUNE_ATTR(complain_secs, 0);

TUNE_ATTR(statfs_slow, 0);

TUNE_ATTR(new_files_jdata, 0);

TUNE_ATTR(quota_simul_sync, 1);

TUNE_ATTR(statfs_quantum, 1);

TUNE_ATTR_3(quota_scale, quota_scale_show, quota_scale_store);
@@ -597,7 +596,6 @@ static struct attribute *tune_attrs[] = { 
	&tune_attr_max_readahead.attr,

	&tune_attr_complain_secs.attr,

	&tune_attr_statfs_slow.attr,

	&tune_attr_quota_simul_sync.attr,

	&tune_attr_statfs_quantum.attr,

	&tune_attr_quota_scale.attr,

	&tune_attr_new_files_jdata.attr,