Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bda63586 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Mark Brown
Browse files

firmware: Sigma: Fix endianess issues 



Currently the SigmaDSP firmware loader only works correctly on little-endian
systems. Fix this by using the proper endianess conversion functions.

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Acked-by: default avatarMike Frysinger <vapier@gentoo.org>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Cc: stable@kernel.org
parent c56935bd

drivers/firmware/sigma.c

+1 −1
Original line number Diff line number Diff line
@@ -133,7 +133,7 @@ int process_sigma_firmware(struct i2c_client *client, const char *name) 
	crc = crc32(0, fw->data + sizeof(*ssfw_head),

			fw->size - sizeof(*ssfw_head));

	pr_debug("%s: crc=%x\n", __func__, crc);

	if (crc != ssfw_head->crc)

	if (crc != le32_to_cpu(ssfw_head->crc))

		goto done;



	ssfw.pos = sizeof(*ssfw_head);

include/linux/sigma.h

+4 −4
Original line number Diff line number Diff line
@@ -24,7 +24,7 @@ struct sigma_firmware { 
struct sigma_firmware_header {

	unsigned char magic[7];

	u8 version;

	u32 crc;

	__le32 crc;

};



enum {
@@ -40,14 +40,14 @@ enum { 
struct sigma_action {

	u8 instr;

	u8 len_hi;

	u16 len;

	u16 addr;

	__le16 len;

	__be16 addr;

	unsigned char payload[];

};



static inline u32 sigma_action_len(struct sigma_action *sa)

{

	return (sa->len_hi << 16) | sa->len;

	return (sa->len_hi << 16) | le16_to_cpu(sa->len);

}



extern int process_sigma_firmware(struct i2c_client *client, const char *name);