Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bbeb0ead authored by Peter Christensen's avatar Peter Christensen Committed by David S. Miller
Browse files

macvlan: Don't propagate IFF_ALLMULTI changes on down interfaces. 



Clearing the IFF_ALLMULTI flag on a down interface could cause an allmulti
overflow on the underlying interface.

Attempting the set IFF_ALLMULTI on the underlying interface would cause an
error and the log message:

"allmulti touches root, set allmulti failed."

Signed-off-by: default avatarPeter Christensen <pch@ordbogen.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1a466ae9

drivers/net/macvlan.c

+4 −2
Original line number Diff line number Diff line
@@ -458,9 +458,11 @@ static void macvlan_change_rx_flags(struct net_device *dev, int change) 
	struct macvlan_dev *vlan = netdev_priv(dev);

	struct net_device *lowerdev = vlan->lowerdev;



	if (dev->flags & IFF_UP) {

		if (change & IFF_ALLMULTI)

			dev_set_allmulti(lowerdev, dev->flags & IFF_ALLMULTI ? 1 : -1);

	}

}



static void macvlan_set_mac_lists(struct net_device *dev)

{