Commit bb472baa authored Jun 14, 2017 by Dan Carpenter Committed by Christoph Hellwig Jun 15, 2017

nvme-rdma: fix error code in nvme_rdma_create_ctrl()



We accidentally return ERR_PTR(0) which is NULL.  The caller isn't
explicitly checking for that but I couldn't immediately spot whether
this would lead to a NULL dereference.  Anyway, we can fix add an
error code easily enough.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent 97ddc36e

drivers/nvme/host/rdma.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1919,12 +1919,14 @@ static struct nvme_ctrl nvme_rdma_create_ctrl(struct device dev,
		/* sanity check icdoff */
		if (ctrl->ctrl.icdoff) {
		dev_err(ctrl->ctrl.device, "icdoff is not supported!\n");
		ret = -EINVAL;
		goto out_remove_admin_queue;
		}

		/* sanity check keyed sgls */
		if (!(ctrl->ctrl.sgls & (1 << 20))) {
		dev_err(ctrl->ctrl.device, "Mandatory keyed sgls are not support\n");
		ret = -EINVAL;
		goto out_remove_admin_queue;
		}