Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit baeb7ef3 authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Greg Kroah-Hartman
Browse files

tty: serial: 8250: use 32bit variable for rpm_tx_active 



The kbuild test robot wrote me:
|  make.cross ARCH=powerpc
|>> ERROR: ".__xchg_called_with_bad_pointer" [drivers/tty/serial/8250/8250.ko] undefined!

The generic implementation of xchg() on arm and x86 works for variables of
size one bye (char). According to the report powerpc does not support
xchg() for one byte sized variables and looking further it seems also to
be the same case for sparc and tile (or for 10 out of 26 architectures
which provide a custom implementation).
For that reason I increase the size of the variable from one to four
bytes to get it work on powerpc (and the others).

Reported-By: default avatarkbuild test robot <fengguang.wu@intel.com>
Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0efe7296

include/linux/serial_8250.h

+1 −1
Original line number Diff line number Diff line
@@ -84,7 +84,7 @@ struct uart_8250_port { 
	unsigned char		mcr_mask;	/* mask of user bits */

	unsigned char		mcr_force;	/* mask of forced bits */

	unsigned char		cur_iotype;	/* Running I/O type */

	unsigned char		rpm_tx_active;

	unsigned int		rpm_tx_active;



	/*

	 * Some bits in registers are cleared on a read, so they must