Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bab383de authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Greg Kroah-Hartman
Browse files

auxdisplay: ks0108: fix refcount 



parport_find_base() will implicitly do parport_get_port() which
increases the refcount. Then parport_register_device() will again
increment the refcount. But while unloading the module we are only
doing parport_unregister_device() decrementing the refcount only once.
We add an parport_put_port() to neutralize the effect of
parport_get_port().

Cc: <stable@vger.kernel.org> # 2.6.32+
Signed-off-by: default avatarSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d25ded8d

drivers/auxdisplay/ks0108.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -139,6 +139,7 @@ static int __init ks0108_init(void) 




	ks0108_pardevice = parport_register_device(ks0108_parport, KS0108_NAME,

	ks0108_pardevice = parport_register_device(ks0108_parport, KS0108_NAME,

		NULL, NULL, NULL, PARPORT_DEV_EXCL, NULL);

		NULL, NULL, NULL, PARPORT_DEV_EXCL, NULL);

	parport_put_port(ks0108_parport);

	if (ks0108_pardevice == NULL) {

	if (ks0108_pardevice == NULL) {

		printk(KERN_ERR KS0108_NAME ": ERROR: "

		printk(KERN_ERR KS0108_NAME ": ERROR: "

			"parport didn't register new device\n");

			"parport didn't register new device\n");