Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b914152a authored by J. Bruce Fields's avatar J. Bruce Fields Committed by J. Bruce Fields
Browse files

nfsd: fix cred leak on every rpc



Since override_creds() took its own reference on new, we need to release
our own reference.

(Note the put_cred on the return value puts the *old* value of
current->creds, not the new passed-in value).

Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
parent bf935a78
Loading
Loading
Loading
Loading
+1 −0
Original line number Original line Diff line number Diff line
@@ -87,6 +87,7 @@ int nfsd_setuser(struct svc_rqst *rqstp, struct svc_export *exp)
		new->cap_effective = cap_raise_nfsd_set(new->cap_effective,
		new->cap_effective = cap_raise_nfsd_set(new->cap_effective,
							new->cap_permitted);
							new->cap_permitted);
	put_cred(override_creds(new));
	put_cred(override_creds(new));
	put_cred(new);
	return 0;
	return 0;


oom:
oom: