Unverified Commit b8110a87 authored Jul 13, 2018 by Dan Carpenter Committed by Mark Brown Jul 13, 2018

ASoC: qdsp6: q6afe-dai: fix a range check in of_q6afe_parse_dai_data()



The main thing is that the data->priv[] array has AFE_PORT_MAX elements
so the > condition should be >=.  But we may as well check for negative
values as well just to be safe.

Fixes: 24c4cbcf ("ASoC: qdsp6: q6afe: Add q6afe dai driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 5dffc175

sound/soc/qcom/qdsp6/q6afe-dai.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1183,7 +1183,7 @@ static void of_q6afe_parse_dai_data(struct device *dev,
		int id, i, num_lines;

		ret = of_property_read_u32(node, "reg", &id);
		if (ret \|\| id > AFE_PORT_MAX) {
		if (ret \|\| id < 0 \|\| id >= AFE_PORT_MAX) {
		dev_err(dev, "valid dai id not found:%d\n", ret);
		continue;
		}