Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6ddc4e6 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Lachlan McIlroy
Browse files

[XFS] Don't validate symlink target component length 



This target component validation is not POSIX conformant and it is not
done by any other Linux filesystem so remove it from XFS.

SGI-PV: 980080
SGI-Modid: xfs-linux-melb:xfs-kern:30776a

Signed-off-by: default avatarChristoph Hellwig <hch@infradead.org>
Signed-off-by: default avatarDavid Chinner <dgc@sgi.com>
Signed-off-by: default avatarLachlan McIlroy <lachlan@sgi.com>
parent 34a622b2

fs/xfs/xfs_vnodeops.c

+0 −25
Original line number Diff line number Diff line
@@ -3105,31 +3105,6 @@ xfs_symlink( 
	pathlen = strlen(target_path);

	if (pathlen >= MAXPATHLEN)      /* total string too long */

		return XFS_ERROR(ENAMETOOLONG);

	if (pathlen >= MAXNAMELEN) {    /* is any component too long? */

		int len, total;

		char *path;



		for (total = 0, path = target_path; total < pathlen;) {

			/*

			 * Skip any slashes.

			 */

			while(*path == '/') {

				total++;

				path++;

			}



			/*

			 * Count up to the next slash or end of path.

			 * Error out if the component is bigger than MAXNAMELEN.

			 */

			for(len = 0; *path != '/' && total < pathlen;total++, path++) {

				if (++len >= MAXNAMELEN) {

					error = ENAMETOOLONG;

					return error;

				}

			}

		}

	}



	if (DM_EVENT_ENABLED(dp, DM_EVENT_SYMLINK)) {

		error = XFS_SEND_NAMESP(mp, DM_EVENT_SYMLINK, dp,