Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6b18aa8 authored by Laszlo Toth's avatar Laszlo Toth Committed by Linus Torvalds
Browse files

mm, soft_offline: improve hugepage soft offlining error log 

On a failed attempt, we get the following entry: soft offline: 0x3c0000:
migration failed 1, type 17ffffc0008008 (uptodate|head)

Make this more specific to be straightforward and to follow other error
log formats in soft_offline_huge_page().

Link: http://lkml.kernel.org/r/20171016171757.GA3018@ubuntu-desk-vm


Signed-off-by: default avatarLaszlo Toth <laszlth@gmail.com>
Acked-by: default avatarNaoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 00bb31fa

mm/memory-failure.c

+1 −1
Original line number Diff line number Diff line
@@ -1587,7 +1587,7 @@ static int soft_offline_huge_page(struct page *page, int flags) 
	ret = migrate_pages(&pagelist, new_page, NULL, MPOL_MF_MOVE_ALL,

				MIGRATE_SYNC, MR_MEMORY_FAILURE);

	if (ret) {

		pr_info("soft offline: %#lx: migration failed %d, type %lx (%pGp)\n",

		pr_info("soft offline: %#lx: hugepage migration failed %d, type %lx (%pGp)\n",

			pfn, ret, page->flags, &page->flags);

		if (!list_empty(&pagelist))

			putback_movable_pages(&pagelist);