Commit b6263178 authored Feb 06, 2017 by Masami Hiramatsu Committed by Ingo Molnar Feb 06, 2017

kprobes/x86: Use hlist_for_each_entry() instead of hlist_for_each_entry_safe()



Use hlist_for_each_entry() in the first loop in the kretprobe
trampoline_handler() function, because it doesn't change the hlist.

Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/148637493309.19245.12546866092052500584.stgit@devbox


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent cd1ee3b1

arch/x86/kernel/kprobes/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -745,7 +745,7 @@ __visible __used void trampoline_handler(struct pt_regs regs)
		* will be the real return address, and all the rest will
		* point to kretprobe_trampoline.
		*/
		hlist_for_each_entry_safe(ri, tmp, head, hlist) {
		hlist_for_each_entry(ri, head, hlist) {
		if (ri->task != current)
		/* another task is sharing our hash bucket */
		continue;