Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b5ffc856 authored by Qiang Huang's avatar Qiang Huang Committed by Linus Torvalds
Browse files

memcg: correct comments for __mem_cgroup_begin_update_page_stat 



Signed-off-by: default avatarQiang Huang <h.huangqiang@huawei.com>
Acked-by: default avatarMichal Hocko <mhocko@suse.cz>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent bdcbb659

mm/memcontrol.c

+4 −5
Original line number Diff line number Diff line
@@ -2276,12 +2276,11 @@ bool mem_cgroup_oom_synchronize(bool handle) 
}



/*

 * Currently used to update mapped file statistics, but the routine can be

 * generalized to update other statistics as well.

 * Used to update mapped file or writeback or other statistics.

 *

 * Notes: Race condition

 *

 * We usually use page_cgroup_lock() for accessing page_cgroup member but

 * We usually use lock_page_cgroup() for accessing page_cgroup member but

 * it tends to be costly. But considering some conditions, we doesn't need

 * to do so _always_.

 *
@@ -2295,8 +2294,8 @@ bool mem_cgroup_oom_synchronize(bool handle) 
 * by flags.

 *

 * Considering "move", this is an only case we see a race. To make the race

 * small, we check mm->moving_account and detect there are possibility of race

 * If there is, we take a lock.

 * small, we check memcg->moving_account and detect there are possibility

 * of race or not. If there is, we take a lock.

 */



void __mem_cgroup_begin_update_page_stat(struct page *page,