Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b5dada82 authored by Damien Lespiau's avatar Damien Lespiau Committed by Jani Nikula
Browse files

drm/i915/bxt: Fix wrongly placed ')' in I915_READ() 



Not the first time! not the last time?

There is a possibility to use gcc 5's -Wbool-compare to try and compare
(reg) in those macros to a constant and gcc will warn that the
comparison between a boolean expression and a constant is always either
true or false. Maybe.

Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: default avatarDamien Lespiau <damien.lespiau@intel.com>
Reviewed-by: default avatarImre Deak <imre.deak@intel.com>
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
parent 9aa61142

drivers/gpu/drm/i915/intel_ddi.c

+1 −1
Original line number Diff line number Diff line
@@ -2882,7 +2882,7 @@ static bool bxt_ddi_pll_get_hw_state(struct drm_i915_private *dev_priv, 
	 * here just read out lanes 0/1 and output a note if lanes 2/3 differ.

	 */

	hw_state->pcsdw12 = I915_READ(BXT_PORT_PCS_DW12_LN01(port));

	if (I915_READ(BXT_PORT_PCS_DW12_LN23(port) != hw_state->pcsdw12))

	if (I915_READ(BXT_PORT_PCS_DW12_LN23(port)) != hw_state->pcsdw12)

		DRM_DEBUG_DRIVER("lane stagger config different for lane 01 (%08x) and 23 (%08x)\n",

				 hw_state->pcsdw12,

				 I915_READ(BXT_PORT_PCS_DW12_LN23(port)));