Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b57f2f61 authored by Philip Rakity's avatar Philip Rakity Committed by Anton Vorontsov
Browse files

max8925_power: Do not read random data from chip registers 



Reading the voltage, charge etc requires that we tell the chip
what property we want to read before reading it according to
maxim.

Signed-off-by: default avatarPhilip Rakity <prakity@marvell.com>
Signed-off-by: default avatarThomas Liu <Thomas.Liu@maxim-ic.com>
Tested-by: default avatarTed Bennett <tbennett@marvell.com>
Signed-off-by: default avatarAnton Vorontsov <cbouatmailru@gmail.com>
parent 60a1f6e4

drivers/power/max8925_power.c

+6 −0
Original line number Diff line number Diff line
@@ -160,25 +160,31 @@ static irqreturn_t max8925_charger_handler(int irq, void *data) 
static int start_measure(struct max8925_power_info *info, int type)

{

	unsigned char buf[2] = {0, 0};

	int meas_cmd;

	int meas_reg = 0, ret;



	switch (type) {

	case MEASURE_VCHG:

		meas_cmd = MAX8925_CMD_VCHG;

		meas_reg = MAX8925_ADC_VCHG;

		break;

	case MEASURE_VBBATT:

		meas_cmd = MAX8925_CMD_VBBATT;

		meas_reg = MAX8925_ADC_VBBATT;

		break;

	case MEASURE_VMBATT:

		meas_cmd = MAX8925_CMD_VMBATT;

		meas_reg = MAX8925_ADC_VMBATT;

		break;

	case MEASURE_ISNS:

		meas_cmd = MAX8925_CMD_ISNS;

		meas_reg = MAX8925_ADC_ISNS;

		break;

	default:

		return -EINVAL;

	}



	max8925_reg_write(info->adc, meas_cmd, 0);

	max8925_bulk_read(info->adc, meas_reg, 2, buf);

	ret = ((buf[0]<<8) | buf[1]) >> 4;