Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b4ccec41 authored by Michal Hocko's avatar Michal Hocko Committed by Linus Torvalds
Browse files

mm/sparse.c: fix typo in online_mem_sections 

online_mem_sections() accidentally marks online only the first section
in the given range.  This is a typo which hasn't been noticed because I
haven't tested large 2GB blocks previously.  All users of
pfn_to_online_page would get confused on the the rest of the pfn range
in the block.

All we need to fix this is to use iterator (pfn) rather than start_pfn.

Link: http://lkml.kernel.org/r/20170904112210.3401-1-mhocko@kernel.org


Fixes: 2d070eab ("mm: consider zone which is not fully populated to have holes")
Signed-off-by: default avatarMichal Hocko <mhocko@suse.com>
Acked-by: default avatarVlastimil Babka <vbabka@suse.cz>
Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent de0c799b

mm/sparse.c

+1 −1
Original line number Diff line number Diff line
@@ -626,7 +626,7 @@ void online_mem_sections(unsigned long start_pfn, unsigned long end_pfn) 
	unsigned long pfn;



	for (pfn = start_pfn; pfn < end_pfn; pfn += PAGES_PER_SECTION) {

		unsigned long section_nr = pfn_to_section_nr(start_pfn);

		unsigned long section_nr = pfn_to_section_nr(pfn);

		struct mem_section *ms;



		/* onlining code should never touch invalid ranges */