Commit b47b2ec1 authored Jul 12, 2006 by Herbert Xu Committed by David S. Miller Jul 12, 2006

[IPV4]: Fix error handling for fib_insert_node call



The error handling around fib_insert_node was broken because we always
zeroed the error before checking it.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4b260a98

net/ipv4/fib_trie.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1252,8 +1252,8 @@ fn_trie_insert(struct fib_table tb, struct rtmsg r, struct kern_rta *rta,
		*/

		if (!fa_head) {
		fa_head = fib_insert_node(t, &err, key, plen);
		err = 0;
		fa_head = fib_insert_node(t, &err, key, plen);
		if (err)
		goto out_free_new_fa;
		}