Commit b446396b authored Dec 04, 2016 by Benjamin Marzinski Committed by Mike Snitzer Dec 08, 2016

dm space map: always set ev if sm_ll_mutate() succeeds



If no block was allocated or freed, sm_ll_mutate() wasn't setting
*ev, leaving the variable unitialized. sm_ll_insert(),
sm_disk_inc_block(), and sm_disk_new_block() all check ev to see
if there was an allocation event in sm_ll_mutate(), possibly
reading unitialized data.

If no allocation event occured, sm_ll_mutate() should set *ev
to SM_NONE.

Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Acked-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>

parent 0c79ce0b

drivers/md/persistent-data/dm-space-map-common.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -464,7 +464,8 @@ static int sm_ll_mutate(struct ll_disk *ll, dm_block_t b,
		ll->nr_allocated--;
		le32_add_cpu(&ie_disk.nr_free, 1);
		ie_disk.none_free_before = cpu_to_le32(min(le32_to_cpu(ie_disk.none_free_before), bit));
		}
		} else
		*ev = SM_NONE;

		return ll->save_ie(ll, index, &ie_disk);
		}