Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b4178ab5 authored Dec 06, 2006 by Alexey Dobriyan Committed by Linus Torvalds Dec 07, 2006

[PATCH] paride_register(): shuffle return values



paride_register() returns 1 on success, 0 on failure and module init
code looks like

	static int __init foo_init(void)
	{
		return paride_register(&foo) - 1;
	}

which is not what one get used to. Converted to usual 0/-E convention.

In case of kbic driver, unwind registration. It was just

	return (paride_register(&k951)||paride_register(&k971))-1;

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent f4330002

drivers/block/paride/aten.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -149,7 +149,7 @@ static struct pi_protocol aten = {

		static int __init aten_init(void)
		{
		return paride_register(&aten)-1;
		return paride_register(&aten);
		}

		static void __exit aten_exit(void)

drivers/block/paride/bpck.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -464,7 +464,7 @@ static struct pi_protocol bpck = {

		static int __init bpck_init(void)
		{
		return paride_register(&bpck)-1;
		return paride_register(&bpck);
		}

		static void __exit bpck_exit(void)

drivers/block/paride/bpck6.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -265,7 +265,7 @@ static int __init bpck6_init(void)
		printk(KERN_INFO "bpck6: Copyright 2001 by Micro Solutions, Inc., DeKalb IL. USA\n");
		if(verbose)
		printk(KERN_DEBUG "bpck6: verbose debug enabled.\n");
		return paride_register(&bpck6) - 1;
		return paride_register(&bpck6);
		}

		static void __exit bpck6_exit(void)

drivers/block/paride/comm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -205,7 +205,7 @@ static struct pi_protocol comm = {

		static int __init comm_init(void)
		{
		return paride_register(&comm)-1;
		return paride_register(&comm);
		}

		static void __exit comm_exit(void)

drivers/block/paride/dstr.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -220,7 +220,7 @@ static struct pi_protocol dstr = {

		static int __init dstr_init(void)
		{
		return paride_register(&dstr)-1;
		return paride_register(&dstr);
		}

		static void __exit dstr_exit(void)