Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b3ddf584 authored by Joel Fernandes's avatar Joel Fernandes
Browse files

ANDROID: mm: Throttle rss_stat tracepoint 



Previously we were throttling rss_stat tracepoint by checking for 512KB
boundary cross over. We removed that because upstream suggested eBPF or
other ways. However right now, we don't have support for those. Let us
re introduce the patch to throttle and avoid large number of events
which are causing data loss.

Bug: 145972256

Change-Id: I4132133aa36163430069b3ca2f57443940fb90b3
Signed-off-by: default avatarJoel Fernandes <joelaf@google.com>
parent 5f39cd27

include/linux/mm.h

+5 −4
Original line number Original line Diff line number Diff line
@@ -1646,27 +1646,28 @@ static inline unsigned long get_mm_counter(struct mm_struct *mm, int member) 
	return (unsigned long)val;

	return (unsigned long)val;

}

}





void mm_trace_rss_stat(struct mm_struct *mm, int member, long count);

void mm_trace_rss_stat(struct mm_struct *mm, int member, long count,

		       long value);





static inline void add_mm_counter(struct mm_struct *mm, int member, long value)

static inline void add_mm_counter(struct mm_struct *mm, int member, long value)

{

{

	long count = atomic_long_add_return(value, &mm->rss_stat.count[member]);

	long count = atomic_long_add_return(value, &mm->rss_stat.count[member]);





	mm_trace_rss_stat(mm, member, count);

	mm_trace_rss_stat(mm, member, count, value);

}

}





static inline void inc_mm_counter(struct mm_struct *mm, int member)

static inline void inc_mm_counter(struct mm_struct *mm, int member)

{

{

	long count = atomic_long_inc_return(&mm->rss_stat.count[member]);

	long count = atomic_long_inc_return(&mm->rss_stat.count[member]);





	mm_trace_rss_stat(mm, member, count);

	mm_trace_rss_stat(mm, member, count, 1);

}

}





static inline void dec_mm_counter(struct mm_struct *mm, int member)

static inline void dec_mm_counter(struct mm_struct *mm, int member)

{

{

	long count = atomic_long_dec_return(&mm->rss_stat.count[member]);

	long count = atomic_long_dec_return(&mm->rss_stat.count[member]);





	mm_trace_rss_stat(mm, member, count);

	mm_trace_rss_stat(mm, member, count, -1);

}

}





/* Optimized variant when page is already known not to be PageAnon */

/* Optimized variant when page is already known not to be PageAnon */

mm/memory.c

+14 −2
Original line number Original line Diff line number Diff line
@@ -140,8 +140,20 @@ static int __init init_zero_pfn(void) 
}

}

core_initcall(init_zero_pfn);

core_initcall(init_zero_pfn);





void mm_trace_rss_stat(struct mm_struct *mm, int member, long count)

/*

 * Only trace rss_stat when there is a 512kb cross over.

 * Smaller changes may be lost unless every small change is

 * crossing into or returning to a 512kb boundary.

 */

#define TRACE_MM_COUNTER_THRESHOLD 128



void mm_trace_rss_stat(struct mm_struct *mm, int member, long count,

		       long value)

{

{

	long thresh_mask = ~(TRACE_MM_COUNTER_THRESHOLD - 1);



	/* Threshold roll-over, trace it */

	if ((count & thresh_mask) != ((count - value) & thresh_mask))

		trace_rss_stat(mm, member, count);

		trace_rss_stat(mm, member, count);

}

}