tpm, tpm_crb: fail when TPM2 ACPI table contents look corrupted (b371616b) · Commits · e / devices / android_kernel_teracube_emerald

At least some versions of AMI BIOS have corrupted contents in the TPM2 ACPI table and namely the physical address of the control area is set to zero. This patch changes the driver to fail gracefully when we observe a zero address instead of continuing to ioremap. Cc: <stable@vger.kernel.org> Signed-off-by:

Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Reviewed-by:

Peter Huewe <peterhuewe@gmx.de> Signed-off-by:

Peter Huewe <peterhuewe@gmx.de>

drivers/char/tpm/tpm_crb.c

+8 −0

Original line number	Original line	Diff line number	Diff line
	@@ -233,6 +233,14 @@ static int crb_acpi_add(struct acpi_device *device)
	return -ENODEV;		return -ENODEV;
	}		}

			/* At least some versions of AMI BIOS have a bug that TPM2 table has
			* zero address for the control area and therefore we must fail.
			*/
			if (!buf->control_area_pa) {
			dev_err(dev, "TPM2 ACPI table has a zero address for the control area\n");
			return -EINVAL;
			}

	if (buf->hdr.length < sizeof(struct acpi_tpm2)) {		if (buf->hdr.length < sizeof(struct acpi_tpm2)) {
	dev_err(dev, "TPM2 ACPI table has wrong size");		dev_err(dev, "TPM2 ACPI table has wrong size");
	return -EINVAL;		return -EINVAL;