Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b30b3c60 authored by NeilBrown's avatar NeilBrown Committed by Felipe Balbi
Browse files

usb: musb: omap2430: minor cleanups. 



1/ remove incorrect comment (it is a non-blocking notifier)
2/ Use correct symbolic return value for notifier
3/ Make sure otg_notifier_work is cancelled before module exit.

Signed-off-by: default avatarNeilBrown <neilb@suse.de>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent c09d6b51

drivers/usb/musb/omap2430.c

+2 −2
Original line number Diff line number Diff line
@@ -222,7 +222,6 @@ static inline void omap2430_low_level_init(struct musb *musb) 
	musb_writel(musb->mregs, OTG_FORCESTDBY, l);

}



/* blocking notifier support */

static int musb_otg_notifications(struct notifier_block *nb,

		unsigned long event, void *unused)

{
@@ -231,7 +230,7 @@ static int musb_otg_notifications(struct notifier_block *nb, 
	musb->xceiv_event = event;

	schedule_work(&musb->otg_notifier_work);



	return 0;

	return NOTIFY_OK;

}



static void musb_otg_notifier_work(struct work_struct *data_notifier_work)
@@ -386,6 +385,7 @@ static void omap2430_musb_disable(struct musb *musb) 
static int omap2430_musb_exit(struct musb *musb)

{

	del_timer_sync(&musb_idle_timer);

	cancel_work_sync(&musb->otg_notifier_work);



	omap2430_low_level_exit(musb);

	otg_put_transceiver(musb->xceiv);