Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b2fe6be7 authored by Suganath Prabu Subramani's avatar Suganath Prabu Subramani Committed by Martin K. Petersen
Browse files

scsi: mpt3sas: Fix for improper info displayed in var log, while blocking or unblocking the device. 



Return value and Device_handle Arguments passed in correct order
 to match with its format string.

Signed-off-by: default avatarChaitra P B <chaitra.basappa@broadcom.com>
Signed-off-by: default avatarSathya Prakash <sathya.prakash@broadcom.com>
Signed-off-by: default avatarSuganath Prabu S <suganath-prabu.subramani@broadcom.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Reviewed-by: default avatarTomas Henzl <thenzl@redhat.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent f46e7cd3

drivers/scsi/mpt3sas/mpt3sas_scsih.c

+4 −4
Original line number Diff line number Diff line
@@ -2837,7 +2837,7 @@ _scsih_internal_device_block(struct scsi_device *sdev, 
	if (r == -EINVAL)

		sdev_printk(KERN_WARNING, sdev,

		    "device_block failed with return(%d) for handle(0x%04x)\n",

		    sas_device_priv_data->sas_target->handle, r);

		    r, sas_device_priv_data->sas_target->handle);

}



/**
@@ -2867,20 +2867,20 @@ _scsih_internal_device_unblock(struct scsi_device *sdev, 
		sdev_printk(KERN_WARNING, sdev,

		    "device_unblock failed with return(%d) for handle(0x%04x) "

		    "performing a block followed by an unblock\n",

		    sas_device_priv_data->sas_target->handle, r);

		    r, sas_device_priv_data->sas_target->handle);

		sas_device_priv_data->block = 1;

		r = scsi_internal_device_block(sdev);

		if (r)

			sdev_printk(KERN_WARNING, sdev, "retried device_block "

			    "failed with return(%d) for handle(0x%04x)\n",

			    sas_device_priv_data->sas_target->handle, r);

			    r, sas_device_priv_data->sas_target->handle);



		sas_device_priv_data->block = 0;

		r = scsi_internal_device_unblock(sdev, SDEV_RUNNING);

		if (r)

			sdev_printk(KERN_WARNING, sdev, "retried device_unblock"

			    " failed with return(%d) for handle(0x%04x)\n",

			    sas_device_priv_data->sas_target->handle, r);

			    r, sas_device_priv_data->sas_target->handle);

	}

}