Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit b28ad41e authored by Markus Elfring's avatar Markus Elfring Committed by Mark Brown
Browse files

ASoC: cs35l32: Improve two size determinations in cs35l32_i2c_probe() 



Replace the specification of two data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 410afed0

sound/soc/codecs/cs35l32.c

+3 −6
Original line number Diff line number Diff line
@@ -355,9 +355,7 @@ static int cs35l32_i2c_probe(struct i2c_client *i2c_client, 
	unsigned int devid = 0;

	unsigned int reg;





	cs35l32 = devm_kzalloc(&i2c_client->dev, sizeof(struct cs35l32_private),

			       GFP_KERNEL);

	cs35l32 = devm_kzalloc(&i2c_client->dev, sizeof(*cs35l32), GFP_KERNEL);

	if (!cs35l32)

		return -ENOMEM;
@@ -373,8 +371,7 @@ static int cs35l32_i2c_probe(struct i2c_client *i2c_client, 
	if (pdata) {

		cs35l32->pdata = *pdata;

	} else {

		pdata = devm_kzalloc(&i2c_client->dev,

				     sizeof(struct cs35l32_platform_data),

		pdata = devm_kzalloc(&i2c_client->dev, sizeof(*pdata),

				     GFP_KERNEL);

		if (!pdata)

			return -ENOMEM;