Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b23af87a authored by Al Viro's avatar Al Viro Committed by Greg Kroah-Hartman
Browse files

fix multiplication overflow in copy_fdtable() 



[ Upstream commit 4e89b7210403fa4a8acafe7c602b6212b7af6c3b ]

cpy and set really should be size_t; we won't get an overflow on that,
since sysctl_nr_open can't be set above ~(size_t)0 / sizeof(void *),
so nr that would've managed to overflow size_t on that multiplication
won't get anywhere near copy_fdtable() - we'll fail with EMFILE
before that.

Cc: stable@kernel.org # v2.6.25+
Fixes: 9cfe015a (get rid of NR_OPEN and introduce a sysctl_nr_open)
Reported-by: default avatarThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent e7a71903

fs/file.c

+1 −1
Original line number Diff line number Diff line
@@ -70,7 +70,7 @@ static void copy_fd_bitmaps(struct fdtable *nfdt, struct fdtable *ofdt, 
 */

static void copy_fdtable(struct fdtable *nfdt, struct fdtable *ofdt)

{

	unsigned int cpy, set;

	size_t cpy, set;



	BUG_ON(nfdt->max_fds < ofdt->max_fds);